From 6253156e24a5a6098d477a9374db125c366fef17 Mon Sep 17 00:00:00 2001
From: faiface <faiface@ksp.sk>
Date: Sat, 26 Nov 2016 22:51:20 +0100
Subject: [PATCH] better error checking
---
pixelgl/vertex.go | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/pixelgl/vertex.go b/pixelgl/vertex.go
index 92092ef..a0ed2f4 100644
--- a/pixelgl/vertex.go
+++ b/pixelgl/vertex.go
@@ -215,14 +215,13 @@ func (va *VertexArray) SetVertexAttribute(vertex int, attr VertexAttribute, data
if vertex < 0 || vertex >= va.count {
panic("set vertex attribute error: invalid vertex index")
}
+ if _, ok := va.attrs[attr]; !ok {
+ panic("set vertex attribute error: invalid vertex attribute")
+ }
DoNoBlock(func() {
gl.BindBuffer(gl.ARRAY_BUFFER, va.vbo)
- attrOffset, ok := va.attrs[attr]
- if !ok {
- panic("set vertex attribute error: invalid vertex attribute")
- }
- offset := 8*va.stride*vertex + 8*attrOffset
+ offset := 8*va.stride*vertex + 8*va.attrs[attr]
gl.BufferSubData(gl.ARRAY_BUFFER, offset, 8*len(data), gl.Ptr(data))
gl.BindBuffer(gl.ARRAY_BUFFER, 0)
--
GitLab